Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support mongo 4.10.x connection pool instrumentation #12070

Closed
wants to merge 2 commits into from
Closed

support mongo 4.10.x connection pool instrumentation #12070

wants to merge 2 commits into from

Conversation

123liuziming
Copy link
Contributor

@123liuziming 123liuziming commented Aug 20, 2024 •
edited by trask
Loading

Resolves #12069

@123liuziming 123liuziming requested a review from a team August 20, 2024 12:38
@laurit
Copy link
Contributor

laurit commented Aug 20, 2024

@123liuziming could you add a regression test for this? As all the mongo tests are passing I guess we don't have a test that covers this.

@123liuziming
Copy link
Contributor Author

@123liuziming could you add a regression test for this? As all the mongo tests are passing I guess we don't have a test that covers this.

Yes, I am trying to cover the scenario.

@heyams
Copy link
Contributor

heyams commented Aug 20, 2024

Please add a test for this if you can.

@123liuziming
Copy link
Contributor Author

123liuziming commented Sep 9, 2024 •
edited
Loading

Sorry, I can not find a case to verify the validity of the PR. Even if we don't do context propagation to com.mongodb.internal.connection.DefaultConnectionPool, it seems that the mongo plugin still works fine.

@123liuziming
Copy link
Contributor Author

Seems like the AsyncWorkManagerInstrumentation helps us to propagate the context correctly and make the DefaultConnectionPoolInstrumentation redundant in a way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mongo plugin DefaultConnectionPoolInstrumentation does not support 4.10.x
3 participants
@123liuziming @laurit @heyams